common, server : use the same User-Agent by default#18957
Merged
angt merged 1 commit intoggml-org:masterfrom Jan 20, 2026
Merged
common, server : use the same User-Agent by default#18957angt merged 1 commit intoggml-org:masterfrom
angt merged 1 commit intoggml-org:masterfrom
Conversation
This commit also ensures that if a custom User-Agent is used, it will be the only one sent. Signed-off-by: Adrien Gallouët <angt@huggingface.co>
ngxson
reviewed
Jan 20, 2026
Contributor
ngxson
left a comment
ngxson
left a comment
There was a problem hiding this comment.
the HF backend is hard-coded to only return certain info when User-Agent == "llama-cpp", so this PR will break that.
I think we should simply remove the build_info from UA, don't think it's useful for now
Member
Author
But I've tested before submitting the PR 🤔 |
ngxson
approved these changes
Jan 20, 2026
Member
Author
|
But I was worried about the use of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit also ensures that if a custom User-Agent is used, it will be the only one sent.